fix(scripts/releaser): scope breaking-change check to commits since previous release - #29487
Merged
Merged
Conversation
…revious release The patch-release breaking-change check listed every merged PR labeled release/breaking against the branch with no range filter, so breaking changes from earlier releases on the branch were reported on every subsequent patch. Both the "!" title marker and the release/breaking label are now evaluated only over prevVersion..HEAD, reusing the same PR metadata lookup the release notes use.
Extract the detection loop into findBreakingCommits so it can be exercised with fixtures covering the "!" title marker, labels resolved by merge SHA and by PR number (cherry-picks), and the no-metadata fallback.
f0ssel
marked this pull request as ready for review
September 17, 2026 17:44
aslilac
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch-release breaking-change check in
./scripts/release.shqueried every merged PR labeledrelease/breakingagainst the release branch with no range filter, so breaking changes shipped in earlier patches were reported again on every subsequent patch release.Both the
!title marker and therelease/breakinglabel are now evaluated only overprevVersion..HEAD, using the same PR metadata lookup the release notes already use (ghBuildPRMetadataMap+categorizeCommit). The now-unusedghListPRsWithLabelis removed and the metadata fetch-with-fallback is extracted intoloadPRMetadataso both call sites share it.The GPG signing prompt was already removed on
mainin #27422, so this PR only covers the breaking-change check. Backporting torelease/2.34andrelease/2.35needs both #27422 and this PR;release/2.36only needs this PR.Supersedes #27065.
Generated by Coder Agents on behalf of @f0ssel.