Skip to content

Fix named transformation with spaces #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nitzanj merged 1 commit into from
Oct 22, 2020
Merged

Fix named transformation with spaces #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cloudinary-core/src/main/java/com/cloudinary/Transformation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,10 +675,13 @@ public String generate(Map options) {

List transformations = ObjectUtils.asArray(options.get("transformation"));
boolean allNamed = true;
for (Object baseTransformation : transformations) {
for ( int i =0; i < transformations.size(); i++ ){
Object baseTransformation = transformations.get(i);
if (baseTransformation instanceof Map) {
allNamed = false;
break;
} else if (baseTransformation instanceof String){
transformations.set(i, ((String) baseTransformation).replaceAll(" ", "%20"));
}
}
String namedTransformation = null;
Expand Down
8 changes: 8 additions & 0 deletions cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,14 @@ public void testTransformationArray() {
assertEquals(DEFAULT_UPLOAD_PATH + "t_blip.blop/test", result);
}

@Test
public void testNamedTransformationWithSpaces() {
// should support named transformations with spaces
Transformation transformation = new Transformation().named("blip blop");
String result = cloudinary.url().transformation(transformation).generate("test");
assertEquals(DEFAULT_UPLOAD_PATH + "t_blip%20blop/test", result);
}

@Test
public void testBaseTransformations() {
// should support base transformation
Expand Down