Open
Conversation
Contributor
|
I’ve approved this but this repository might be considered obsolete, I wouldn’t be surprised to see an avalanche of failures 😳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades ember-resources to v7.
It also upgrades the dependencies (if outdated) to their new minimum version.
These upgrades should probably happen as separate PRs though.
Implementation of the codemod here: NullVoxPopuli/ember-resources#1147
Here are the breaking changes in v6:
Here are the breaking changes in v7:
reactiveweb, documentation here: https://reactive.nullvoxpopuli.com/Resourceclass has moved to a separate package, https://github.com/NullVoxPopuli/ember-modify-based-class-resource/modify()hooks -- as they are a sort of backdoor effect, which we don't want to encourage -- instead folks should rely on more data derivation patternsPossible remaining steps to do: