Open
Conversation
tintinthong
force-pushed
the
fix-export-of-sdk
branch
from
6a22773 to
1414179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index.tsis not available insidedistwhen @cardstack/cardpay-sdk is distributed. A lot of apps (web-client) default to using themainproperty ie./dist/esm/index.jsHere is a comment which explains this change but I am not too certain of the reason behind it.
I guess using test and the cli in the monorepo would import
index.ts? Btw the test are failing so this PR is not in a working state altho the import doesn't seem to work.It is blocking this PR