Skip to content

Allow json comments#415

Merged
bugy merged 9 commits into
bugy:masterfrom
brunomgalmeida:allow-json-comments
Jun 24, 2021
Merged

Allow json comments#415
bugy merged 9 commits into
bugy:masterfrom
brunomgalmeida:allow-json-comments

Conversation

@brunomgalmeida

Copy link
Copy Markdown
Contributor

This may be useful, to document scripts or features

@bugy

bugy commented Mar 24, 2021

Copy link
Copy Markdown
Owner

Hi @brunomgalmeida I think this is a helpful feature.
However, I prefer to avoid adding extra dependencies without extra need for several reasons:

  1. It breaks backward compatibility somehow (after installing new version, the server won't start)
  2. Some dependencies might introduce security risk or just some bugs, and being not very popular, the risk is higher
  3. I would like to keep machines as lightweight as possible

@bugy bugy left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I left a couple of comments

Also, I think these places should be updated as well:

  • auth_ldap:255
  • config_service:192
  • script_config:246
  • schedule_service:38

Comment thread samples/conf.json Outdated
Comment thread src/migrations/migrate.py
Comment thread src/utils/custom_json.py Outdated
Comment thread src/utils/custom_json.py Outdated
Comment thread src/model/server_conf.py
Comment thread src/config/config_service.py

@bugy bugy left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bugy bugy merged commit 61319a0 into bugy:master Jun 24, 2021
@bugy bugy added the feature label Jun 24, 2021
@bugy bugy added this to the 1.17.0 milestone Jun 24, 2021
@bugy bugy added the resolved label Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants