secret_storage_file config param for store cookie secret#306
Merged
Conversation
Owner
|
Hi @miksir thanks for your changes, they definitely make sense! |
Author
|
IMHO no. TEMP folder is for temporary files which is safe to delete. Temporary files should not change application behavior if removed. But files with any kind of state - it's not temporary file. In point of linux directories view - it's or /etc (config) or /var. IMHO it's much closer to config, many frameworks even has config option "secret key" for hmac signing. |
Owner
|
Hmm, maybe Script server should store the secret file in the config folder then? |
Author
|
May be :) as for me - separate path is better because conf folder mounted as ro volume to container |
Owner
|
ok :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
secret_storage_fileoption for move secure cookie key file. Otherwise cookie reseted on docker container recreation.