Logs - replace forward slash (/) with underscore#268
Merged
Conversation
FileNotFoundError: [Errno 2] No such file or directory: 'logs/processes/Group_add/remove_a_member_<host>_200307_134140.log'
Owner
|
Nice catch! Thanks a lot! |
bugy
approved these changes
Mar 7, 2020
Owner
|
@autogun hmm, I had wrong tests, now they are failing because of wrongly expected name |
Contributor
Author
|
@bugy IMHO, back & forward slashes should be avoided when it comes to naming conventions. See if agree to the test fix :) |
Owner
|
@autogun ye, it's better to avoid slashes. Don't know why I used it for the test :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was playing with script-server for the first time today and noticed you cannot use '/' in the script name as it breaks the logging on the filesystem due to... well, obvious reasons :-)
There might be a better approach to do this as more chars may break this.
For your consideration