Mobile Web Client#85
Merged
Merged
Conversation
| (if (or (nil? group-id) (some? (get-in state [:groups group-id]))) | ||
| (assoc state :open-group-id group-id :page page-id) | ||
| (assoc state :open-group-id nil :page {:type :index})))) | ||
| (assoc state :open-group-id group-id :page page-id))) |
Contributor
There was a problem hiding this comment.
The check was there to prevent weird behaviour if one tried to navigate to a url with a bad group-id.
Contributor
|
One comment, but I'd like to just merge this ASAP - makes me uncomfortable to have live code that isn't from master :S |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A preliminary mobile web client. Still lots of room for UI improvements and not feature parity with the desktop client, but, usable.