Finished all of Basic Javascript#55
Closed
47analogy wants to merge 4 commits into
Closed
Conversation
ryan-hamblin
reviewed
Sep 8, 2017
ryan-hamblin
left a comment
ryan-hamblin
left a comment
Contributor
There was a problem hiding this comment.
Great work. I didn't spot any glaring holes in your formatting. All seems well written and put together. I don't have anything constructive at this time.
| // if language is undefined return 'Hello!' | ||
| if (language === 'German') { | ||
| return 'Guten Tag!'; | ||
| } else if (language === 'English') { |
Contributor
There was a problem hiding this comment.
If English is defaulted at the end, this else if statement is arbitrary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a little trouble with the pull request, but hope all is well now