Channel member self-reference causes uncontrolled recursion#1345
Merged
skarg merged 3 commits intoMay 13, 2026
Merged
Conversation
…rence check for channel members
…rences and improve error handling
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Channel object against unbounded recursive writes caused by self-referential entries in PROP_LIST_OF_OBJECT_PROPERTY_REFERENCES, preventing WriteProperty(PROP_PRESENT_VALUE) from re-entering the Channel write path indefinitely.
Changes:
- Adds a re-entrancy guard in
Channel_Write_Members()usingWrite_Statusto stop recursive member expansion. - Rejects direct self-references to the same Channel’s
PROP_PRESENT_VALUEwhen writingPROP_LIST_OF_OBJECT_PROPERTY_REFERENCES. - Refactors array-element decoding for
PROP_LIST_OF_OBJECT_PROPERTY_REFERENCESandPROP_CONTROL_GROUPSto use type-specific decoders and clearer error mapping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lect success or failure of property writes
skarg
deleted the
bugfix/channel-member-self-reference-uncontrolled-recursion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROP_LIST_OF_OBJECT_PROPERTY_REFERENCES accepts a self-referential entry pointing back to the same Channel object's PROP_PRESENT_VALUE. A subsequent WriteProperty request to that Channel object's PROP_PRESENT_VALUE causes the implementation to re-expand the persisted member reference through the internal Device_Write_Property callback, creating an unbounded recursive loop:
Channel_Write_Property -> Channel_Present_Value_Write -> Channel_Write_Members -> Device_Write_Property -> Channel_Write_Property -> ...