feat: add proprietary object functions to device object list#1343
Merged
skarg merged 4 commits intoMay 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for extending the Device object’s object-function table at runtime (aimed at proprietary object types) by switching the server-basic Device object list storage to a key-sorted container and adding tests around the new APIs.
Changes:
- Replaced the server-basic
Object_Tableimplementation with aKeylistto enable dynamic lookup/indexing and adding of object-function entries. - Added new exported APIs for finding/indexing/adding/initializing object-function entries, plus a new unit test for those APIs.
- Updated create/delete object tests to validate object validity rather than relying on instance/count expectations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/bacnet/basic/server/bacnet_device.c |
Migrates object-function table to Keylist and updates object-list iteration to use index-based access. |
src/bacnet/basic/object/device.h |
Exposes new object-function table APIs via the public Device header. |
test/bacnet/basic/server/bacnet_device/src/main.c |
Adds tests for the new object-function APIs and adjusts create/delete assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.