Fix doctests test path#2518
Closed
eteq wants to merge 2 commits into
Closed
Conversation
Member
|
@eteq - this PR should be made to astropy-helpers instead (feel free to close this one) |
Member
Author
|
@astrofrog - this is in astropy/astropy-helpers#44 now, so I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing for #2512 and #2513 I noticed that the
docs-pathoption topython setup.py testis not respected. This is because it uses a relative path even when the docs build happens in a temporary directory that doesn't include the sphinx source. So this just locks in the absolute path at the time the test command is triggered, rather then when the tests are actually running (which is in a separate process).It also clarifies the help information for the
-toption, which I realized interacts in a confusing way with thedocs-pathdescritpion