Skip to content

Fix doctests test path#2518

Closed
eteq wants to merge 2 commits into
astropy:masterfrom
eteq:fix-docs-test-path
Closed

Fix doctests test path#2518
eteq wants to merge 2 commits into
astropy:masterfrom
eteq:fix-docs-test-path

Conversation

@eteq

@eteq eteq commented May 19, 2014

Copy link
Copy Markdown
Member

While testing for #2512 and #2513 I noticed that the docs-path option to python setup.py test is not respected. This is because it uses a relative path even when the docs build happens in a temporary directory that doesn't include the sphinx source. So this just locks in the absolute path at the time the test command is triggered, rather then when the tests are actually running (which is in a separate process).

It also clarifies the help information for the -t option, which I realized interacts in a confusing way with the docs-path descritpion

@eteq eteq added Bug labels May 19, 2014
@eteq eteq added this to the v0.4.0 milestone May 19, 2014
@astrofrog

Copy link
Copy Markdown
Member

@eteq - this PR should be made to astropy-helpers instead (feel free to close this one)

@eteq

eteq commented Jun 12, 2014

Copy link
Copy Markdown
Member Author

@astrofrog - this is in astropy/astropy-helpers#44 now, so I'll close this.

@eteq eteq closed this Jun 12, 2014
@eteq eteq deleted the fix-docs-test-path branch June 12, 2014 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants