Skip to content

Cosmology doc update after deprecating the functional interface#2507

Merged
astrofrog merged 4 commits into
astropy:masterfrom
nhmc:cosmology_doc_update
May 19, 2014
Merged

Cosmology doc update after deprecating the functional interface#2507
astrofrog merged 4 commits into
astropy:masterfrom
nhmc:cosmology_doc_update

Conversation

@nhmc

@nhmc nhmc commented May 17, 2014

Copy link
Copy Markdown
Contributor

Here are the documentation changes for the cosmology package as discussed in #2343. I altered the Getting Started section, merged the For Developers and Default Cosmology sections and moved them to the end, and made some other minor changes.

@nhmc

nhmc commented May 17, 2014

Copy link
Copy Markdown
Contributor Author

@aconley and @eteq might want to take a look.

@astrofrog astrofrog added this to the v0.4.0 milestone May 17, 2014
@astrofrog astrofrog mentioned this pull request May 18, 2014
@astrofrog

Copy link
Copy Markdown
Member

This looks good to me! @eteq or @aconley?

Comment thread docs/cosmology/index.rst Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'used' rather than using?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks.

@aconley

aconley commented May 18, 2014

Copy link
Copy Markdown
Contributor

Sorry, I was in 'recovery from proposal writing mode' and not looking at email.

This looks good to me.

Reading the docs, it occurs to me that maybe we should provide a method for a user to make a copy of a cosmology object but with specified inputs. Right now they have to remember all the arguments. I can imagine a use case like: now I want the WMAP9 cosmology but with Om increased by 0.05.

But not a job for this pull.

@astrofrog

Copy link
Copy Markdown
Member

@nhmc @aconley - just to check, is this ready for merging?

@nhmc

nhmc commented May 19, 2014

Copy link
Copy Markdown
Contributor Author

Yep, I think it's ready.

@astrofrog

Copy link
Copy Markdown
Member

Ok, thanks @nhmc!

astrofrog added a commit that referenced this pull request May 19, 2014
Cosmology doc update after deprecating the functional interface
@astrofrog astrofrog merged commit 0361da2 into astropy:master May 19, 2014
@nhmc nhmc deleted the cosmology_doc_update branch May 19, 2014 09:04
@eteq

eteq commented May 20, 2014

Copy link
Copy Markdown
Member

Oops, I should have left a comment indicating I was planning on reviewing this, @astrofrog and @nhmc ... I have a few quite minor comments - none are crucial, but I could either leave them here if you want to implement them in a separate PR @nhmc. Or I can try to make a PR myself (although I might not have time to do that for a while...).

@nhmc

nhmc commented May 20, 2014

Copy link
Copy Markdown
Contributor Author

If you leave the comments here, I can open a new PR.
On 21/05/2014 4:26 AM, "Erik Tollerud" notifications@github.com wrote:

Oops, I should have left a comment indicating I was planning on reviewing
this, @astrofrog https://github.com/astrofrog and @nhmchttps://github.com/nhmc... I have a few quite minor comments - none are crucial, but I could
either leave them here if you want to implement them in a separate PR
@nhmc https://github.com/nhmc. Or I can try to make a PR myself
(although I might not have time to do that for a while...).


Reply to this email directly or view it on GitHubhttps://github.com//pull/2507#issuecomment-43664543
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants