Skip to content

Update document missing params error message#5671

Merged
abnegate merged 2 commits into
masterfrom
feat-update-error-message
Jun 12, 2023
Merged

Update document missing params error message#5671
abnegate merged 2 commits into
masterfrom
feat-update-error-message

Conversation

@abnegate

@abnegate abnegate commented Jun 7, 2023

Copy link
Copy Markdown
Member

What does this PR do?

Add new error message to differentiate between missing data and missing data and permissions between document create and document update.

Test Plan

N/A

Related PRs and Issues

N/A

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@gewenyu99 gewenyu99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this to follow a [What went wrong] | [What we think happened] | [Next steps to try] format

Comment thread app/config/errors.php Outdated
@abnegate abnegate requested a review from gewenyu99 June 9, 2023 01:09

@gewenyu99 gewenyu99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants