fix: adds the missing expire attribute to ListSessions call#4872
Closed
CoderMayhem wants to merge 2 commits into
Closed
fix: adds the missing expire attribute to ListSessions call#4872CoderMayhem wants to merge 2 commits into
CoderMayhem wants to merge 2 commits into
Conversation
stnguyen90
reviewed
Jan 10, 2023
|
|
||
| $session->setAttribute('countryName', $countryName); | ||
| $session->setAttribute('current', ($current == $session->getId()) ? true : false); | ||
| $session->setAttribute('expire', DateTime::addSeconds(new \DateTime($session->getCreatedAt()), $authDuration)); |
Contributor
There was a problem hiding this comment.
The value should be formatted like an ISO string as well.
stnguyen90
suggested changes
Jan 10, 2023
stnguyen90
left a comment
stnguyen90
left a comment
Contributor
There was a problem hiding this comment.
Great PR! 🤯 We left some comments during the review, please check them out.
Contributor
|
@CoderMayhem are you still able to work on this PR or should this be reassigned? |
Author
|
Hey @stnguyen90, looks like I missed your comment. I apologize. I'll do the changes requested and push them. |
Contributor
|
@CoderMayhem, how's your progress on this? Also, it looks like there's a merge conflict now. |
Contributor
|
@CoderMayhem, FYI, I'll need to close this due to inactivity soon. |
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the missing
expireattribute to the ListSessions response. Linked to issue #4846Test Plan
Changes were done as suggested in the issue discussion thread by @stnguyen90. I couldn't figure out a way to test it and would appreciate any help in setting up a dummy call to the API and check for ListSessions output.
Related PRs and Issues
Fixes #4846
Have you added your change to the Changelog?
Yes
(The CHANGES.md file tracks all the changes that make it to the
mainbranch. Add your change to this file in the following format)Have you read the Contributing Guidelines on issues?
Yes