Conversation
Superskyyy
commented
Jan 17, 2023
kezhenxu94
previously approved these changes
Jan 18, 2023
Member
kezhenxu94
left a comment
kezhenxu94
left a comment
There was a problem hiding this comment.
LGTM when you mark it ready for review and CI passed 🧐
Member
Author
It will likely stuck forever 😂 Just found out there was a missed system-level dependency (for mysql-client) in the image. I'm fixing it right now. |
…python into slim-ci-image
Member
Author
|
I also updated compose retries and ci output logic. It will never hang for 30minutes anymore. |
kezhenxu94
previously approved these changes
Jan 18, 2023
Member
Author
|
zzZ my bad again. |
wu-sheng
previously approved these changes
Jan 18, 2023
Member
Author
|
Finially😔 |
wu-sheng
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use slim to avoid long artifact build/download time in actions. (image size reduced by half)
If I understand correctly slim is only different in terms of minimal external-to-python libs and should in no way interfere with plugin tests. (build-essential is additionally installed in image)
Please indicate if there's potential risk in this one.
CHANGELOG.md.