feat(fs): introduce file system tests#42
Merged
Conversation
leaves12138
requested changes
Jun 2, 2026
Contributor
leaves12138
left a comment
leaves12138
left a comment
There was a problem hiding this comment.
I found a standalone build blocker: this PR is based on current main, but the new tests include local file system headers that are only introduced by PR #41 and are not present in this PR's base. Please either rebase this PR onto the local file system PR after it is ready/merged, or make this PR self-contained before merging.
| #include "paimon/factories/factory_creator.h" | ||
| #include "paimon/fs/file_system.h" | ||
| #include "paimon/fs/file_system_factory.h" | ||
| #include "paimon/fs/local/local_file_system_factory.h" |
Contributor
There was a problem hiding this comment.
This header does not exist on this PR's base (main at 445feeb...) or in this PR's diff; it is introduced by PR #41. As a result, PR #42 is not buildable as a standalone PR against its current base. Please either stack/rebase this PR onto #41 after that dependency is ready, or include/remove the dependency here.
leaves12138
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: None
Introduce file system test coverage migrated from the Alibaba Paimon C++ repository.
This PR adds:
FileSystemunit coverageResolvingFileSystemunit coverageExternalPathProviderand its unit coverageThe requested migration scope is limited to the test files under
src/paimon/common/fsplusexternal_path_provider.h. Local file system implementation dependencies are intentionally kept out of this PR and are covered by #41.License handling:
LICENSE/NOTICE; no third-party declaration updates were required for these files.External contributor handling:
Co-authored-bytrailer or PR thank-you comment is needed.Tests
git diff --checkAPI and Format
This adds
ExternalPathProviderundersrc/paimon/common/fsfor external data path selection. It does not change public storage format or protocol.Documentation
No documentation changes.
Generative AI tooling
Migrated-by: OpenAI Codex