add a feature to use redirect instead of popup -add a demo for this new feature#2
Open
clakech wants to merge 1 commit intoangular-oauth:masterfrom
Open
add a feature to use redirect instead of popup -add a demo for this new feature#2clakech wants to merge 1 commit intoangular-oauth:masterfrom
clakech wants to merge 1 commit intoangular-oauth:masterfrom
Conversation
-add a demo for this new feature warning: I reuse the same callback url because I don't have access to the config
|
+1 for a redirect feature! |
Contributor
|
Just one comment here: In some OAuth implementations, as in LinkedIn's (https://developer.linkedin.com/documents/authentication), Just trying to avoid future issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warning: I reuse the same callback url because I don't have access to the
config