Changes to oAuth callback and state verification#13
Open
maciekrb wants to merge 9 commits intoangular-oauth:masterfrom
Open
Changes to oAuth callback and state verification#13maciekrb wants to merge 9 commits intoangular-oauth:masterfrom
maciekrb wants to merge 9 commits intoangular-oauth:masterfrom
Conversation
Adding a stub for getTokenType()
Full token info is now stored in localStorage. If user reloads the page TokenProvider can be configured to load configuration from the localStorage info.
|
Actually I need that state verification so this library is useful to me. I hope that pull request is accepted :) |
Created factories to config authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I found that the window.postMessage wasn't always working, so a replaced it with just a global scope function (yeah, I know is not that elegant, but it is a bit more compatible), and I added state verification, which is actually sent to the token endpoint and then verified upon callback.
Let me know what you think.
Cheers