Skip to content

fix(material/datepicker): fix failing unit test in multiyear view - #24418

Merged
zarend merged 1 commit into
angular:masterfrom
zarend:fix-jan-3-datepicker-test
Feb 15, 2022
Merged

fix(material/datepicker): fix failing unit test in multiyear view #24418
zarend merged 1 commit into
angular:masterfrom
zarend:fix-jan-3-datepicker-test

Conversation

@zarend

@zarend zarend commented Feb 15, 2022

Copy link
Copy Markdown
Contributor

Fixes the recent CI failures. Please see commit message for description.

@zarend zarend added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release area: material/datepicker labels Feb 15, 2022
@zarend
zarend requested a review from wagnermaciel February 15, 2022 18:56
@zarend
zarend requested a review from mmalerba as a code owner February 15, 2022 18:56
@zarend
zarend force-pushed the fix-jan-3-datepicker-test branch from a5d63a4 to 6e31832 Compare February 15, 2022 18:57

@wagnermaciel wagnermaciel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fix a failing unit test, which was referencing Jan 1, 2017 as the initial
date when it is actually Jan 3, 2017. This happened as a result of a bad
merge where angular#24384 changed the initial date to Jan 3, and angular#24401 added a
new test that assume the initial date was Jan 1.

Fixes CI failure
@zarend
zarend force-pushed the fix-jan-3-datepicker-test branch from 6e31832 to 09abea1 Compare February 15, 2022 19:15
@zarend zarend changed the title refactor(material/datepicker): fix failing unit test fix(material/datepicker): fix failing unit test in multiyear view Feb 15, 2022
@zarend zarend added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 15, 2022
@zarend
zarend merged commit 5603d9b into angular:master Feb 15, 2022
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 18, 2022
@zarend
zarend deleted the fix-jan-3-datepicker-test branch March 29, 2022 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: material/datepicker target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants