Listen for focus event on calendar cells - #24279
Merged
zarend merged 1 commit intoFeb 7, 2022
Merged
Conversation
zarend
force-pushed
the
listen-for-focus-event-on-calendar-cells
branch
from
January 26, 2022 21:46
90e63ed to
0ab736c
Compare
zarend
added
Accessibility
zarend
force-pushed
the
listen-for-focus-event-on-calendar-cells
branch
from
January 26, 2022 21:50
0ab736c to
5b3f379
Compare
|
Deployed dev-app to: https://ng-comp-dev--pr-24279-5b3f379a508e0e1f56b26f1428b4b379-dva346t7.web.app |
zarend
added
the
merge: caretaker note
zarend
removed
the
merge: caretaker note
jelbourn
reviewed
Feb 1, 2022
| '[data-mat-row="1"][data-mat-col="2"] button', | ||
| ) as HTMLElement; | ||
|
|
||
| dispatchFakeEvent(year2022El, 'focus'); |
Contributor
There was a problem hiding this comment.
Would the test worked if you actually focused the element with .focus()?
Contributor
Author
There was a problem hiding this comment.
well, not sure exactly what the question is here. If we changed this line to year2022El.focus() then the test would fail when we check that the focusSpy was not called.
An alternative would be to actually focus the element with .focus(), but assert that the focusSpy was called exactly one.
I went with dispathFakeEvent because that's what we use in all the other tests, but I'm open to suggestions.
zarend
force-pushed
the
listen-for-focus-event-on-calendar-cells
branch
2 times, most recently
from
February 4, 2022 22:57
e35faa8 to
8152864
Compare
Contributor
Author
|
@jelbourn , I've address the PR comments, and this is ready for your eyes again 👀 |
zarend
force-pushed
the
listen-for-focus-event-on-calendar-cells
branch
2 times, most recently
from
February 5, 2022 00:18
cb9b201 to
782f893
Compare
zarend
force-pushed
the
listen-for-focus-event-on-calendar-cells
branch
from
February 5, 2022 01:37
782f893 to
0805774
Compare
When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Fixes angular#23483
zarend
force-pushed
the
listen-for-focus-event-on-calendar-cells
branch
from
February 5, 2022 01:39
0805774 to
e82f7a6
Compare
zarend
added a commit
that referenced
this pull request
Feb 7, 2022
…ell (#24279) When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Fixes #23483 (cherry picked from commit 052b97d)
zarend
added a commit
that referenced
this pull request
Feb 8, 2022
zarend
added a commit
to zarend/components
that referenced
this pull request
Feb 9, 2022
When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Note that this is the second attempt at this. First attempt was angular#24279, which was reverted in angular#24380 due to an internal issue. Fixes angular#23483
zarend
added a commit
that referenced
this pull request
Feb 14, 2022
When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Note that this is the second attempt at this. First attempt was #24279, which was reverted in #24380 due to an internal issue. Fixes #23483
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…ell (angular#24279) When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Fixes angular#23483
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…lendar cell (angular#24279)" (angular#24380) This reverts commit 052b97d.
amysorto
pushed a commit
to amysorto/components
that referenced
this pull request
Feb 15, 2022
…lar#24384) When a a date cell on the calendar recieves focus, set the active date to that cell. This ensures that the active date matches the date with browser focus. Previously, we set the active date on keydown and click, but that was problematic for screenreaders. That's because many screenreaders trigger a focus event instead of a keydown event when using screenreader specific navigation (VoiceOver, Chromevox, NVDA). Note that this is the second attempt at this. First attempt was angular#24279, which was reverted in angular#24380 due to an internal issue. Fixes angular#23483
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please see commit message for description.
Guide to reviewing this
Would probably make the most sense to reviewers to look at code changes in this order:
MatCalendarBody._scheduleFocusActiveCellAfterViewChecked(used for refactoring handingkeydownevents without changing existing behavior)Tests added to src/material/datepicker/month-view.spec.ts(the behavior change this PR creates)MatCalendarBody._cellFocusedMatMonthView._dateBecomesActive