feat(material-experimental/mdc-autocomplete): add panel animation - #21525
Merged
Conversation
google-cla
Bot
added
the
cla: yes
mmalerba
force-pushed
the
autocomplete-anim
branch
from
January 9, 2021 00:02
aa69cb5 to
f4d8a98
Compare
crisbeto
reviewed
Jan 10, 2021
| {provide: MAT_OPTION_PARENT_COMPONENT, useExisting: MatAutocomplete} | ||
| ] | ||
| ], | ||
| animations: [panelAnimation], |
Member
There was a problem hiding this comment.
Should we have this on the non-MDC version too? I think that it may make the switch more difficult, because the timing in people's tests will change.
Contributor
Author
There was a problem hiding this comment.
My guess is adding it in the current one would be too hard to get in. We can try it at least in a separate PR
mmalerba
force-pushed
the
autocomplete-anim
branch
4 times, most recently
from
January 11, 2021 23:25
ca42c41 to
041b7cb
Compare
mmalerba
force-pushed
the
autocomplete-anim
branch
2 times, most recently
from
January 12, 2021 00:12
0047e3c to
3007547
Compare
mmalerba
force-pushed
the
autocomplete-anim
branch
from
January 12, 2021 00:26
3007547 to
9844394
Compare
mmalerba
force-pushed
the
autocomplete-anim
branch
from
January 12, 2021 00:47
9844394 to
68032a1
Compare
Contributor
Author
|
CI issues should be resolved now, PTAL |
crisbeto
approved these changes
Jan 12, 2021
crisbeto
left a comment
crisbeto
left a comment
Member
There was a problem hiding this comment.
LGTM with a couple of nits that aren't blocking.
| transition(':enter, hidden => visible', [ | ||
| group([ | ||
| animate('0.03s linear', style({ opacity: 1 })), | ||
| animate('0.12s cubic-bezier(0, 0, 0.2, 1)', style({ transform: 'scale(1)' })), |
Member
There was a problem hiding this comment.
The indentation seems off here.
| [ngClass]="_classList" | ||
| [attr.aria-label]="ariaLabel || null" | ||
| [attr.aria-labelledby]="_getPanelAriaLabelledby(formFieldId)" | ||
| [@panelAnimation]="isOpen ? 'visible' : 'hidden'" |
Member
There was a problem hiding this comment.
nit: Calling it "*Animation" is redundant since the @ means that it's an animation. We could simplify it to just "panel"?
mmalerba
added a commit
that referenced
this pull request
Jan 13, 2021
…1525) * feat(material-experimental/mdc-autocomplete): add panel animation * fixup! feat(material-experimental/mdc-autocomplete): add panel animation * fixup! feat(material-experimental/mdc-autocomplete): add panel animation * fixup! feat(material-experimental/mdc-autocomplete): add panel animation Co-authored-by: Andrew Seguin <andrewjs@google.com> (cherry picked from commit 8aebd03)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…gular#21525) * feat(material-experimental/mdc-autocomplete): add panel animation * fixup! feat(material-experimental/mdc-autocomplete): add panel animation * fixup! feat(material-experimental/mdc-autocomplete): add panel animation * fixup! feat(material-experimental/mdc-autocomplete): add panel animation Co-authored-by: Andrew Seguin <andrewjs@google.com>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.