fix(material/menu): allow menu height to grow after open - #21436
Merged
Conversation
Currently the menu only shrinks if the users scrolls after it has been opened, but if they scroll back to a place where there's enough place to fit the content, the menu will stay collapsed. These changes adjust the config so the menu can grow after it was opened. Fixes angular#18168. Fixes angular#13988.
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
jelbourn
approved these changes
Jan 5, 2021
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Caretaker note: I suspect a fair amount of screenshot diffs
annieyw
pushed a commit
that referenced
this pull request
Jan 9, 2021
Currently the menu only shrinks if the users scrolls after it has been opened, but if they scroll back to a place where there's enough place to fit the content, the menu will stay collapsed. These changes adjust the config so the menu can grow after it was opened. Fixes #18168. Fixes #13988. (cherry picked from commit 83f2adc)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
Currently the menu only shrinks if the users scrolls after it has been opened, but if they scroll back to a place where there's enough place to fit the content, the menu will stay collapsed. These changes adjust the config so the menu can grow after it was opened. Fixes angular#18168. Fixes angular#13988.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the menu only shrinks if the users scrolls after it has been opened, but
if they scroll back to a place where there's enough place to fit the content, the menu
will stay collapsed.
These changes adjust the config so the menu can grow after it was opened.
Fixes #18168.
Fixes #13988.