Skip to content

fix(google-maps): typo in retina methods - #21419

Merged
annieyw merged 1 commit into
angular:masterfrom
crisbeto:21418/retina-icons-typo
Jan 6, 2021
Merged

fix(google-maps): typo in retina methods#21419
annieyw merged 1 commit into
angular:masterfrom
crisbeto:21418/retina-icons-typo

Conversation

@crisbeto

@crisbeto crisbeto commented Dec 22, 2020

Copy link
Copy Markdown
Member

Fixes a couple of typos in the names of methods in the marker clusterer.

Fixes #21418.

Note: this isn't a breaking change, because the code that introduced the typo hasn't been released yet.

cc @mbehrlich

Fixes a couple of typos in the names of methods in the marker clusterer.

Fixes angular#21418.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Dec 22, 2020
@crisbeto
crisbeto requested a review from a team December 22, 2020 13:21
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 22, 2020
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Dec 22, 2020

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 22, 2020

@Splaktar Splaktar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbehrlich

Copy link
Copy Markdown
Contributor

Good catch!

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw
annieyw merged commit d21a78d into angular:master Jan 6, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
Fixes a couple of typos in the names of methods in the marker clusterer.

Fixes angular#21418.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(map-market-cluster): Typos + import @googlemaps/marketclusterplus

6 participants