fix(material/table): unsubscribe from source when disconnecting - #21338
Merged
Conversation
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
crisbeto
commented
Dec 13, 2020
andrewseguin
approved these changes
Dec 15, 2020
* Fixes that the table data source wasn't unsubscribing from sorting, pagination etc. when it is disconnected. * Adds a bit of logic to properly support re-connecting the same date source again. * Fixes up a couple of issues in the unit test setup which could cause state to leak between tests. Fixes angular#21270.
crisbeto
force-pushed
the
21270/data-source-unsubscribe
branch
from
December 16, 2020 18:37
168b4fd to
5b9f60a
Compare
mmalerba
added
target: minor
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…lar#21338) * Fixes that the table data source wasn't unsubscribing from sorting, pagination etc. when it is disconnected. * Adds a bit of logic to properly support re-connecting the same date source again. * Fixes up a couple of issues in the unit test setup which could cause state to leak between tests. Fixes angular#21270.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21270.