feat(cdk/scrolling): update ScrollDispatcher to allow HTMLElement par… - #21201
Merged
annieyw merged 1 commit intoJan 9, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
crisbeto
reviewed
Dec 3, 2020
crisbeto
left a comment
crisbeto
left a comment
Member
There was a problem hiding this comment.
The changes look good, but you'll have to run yarn approve-api scrolling and commit the changed file for the CI to pass.
…ameters Update ScrollDispatcher API to take elements of either ElementRef or HTMLElement. This is to maintain consistency with newer APIs.
BobobUnicorn
force-pushed
the
scroll-dispatcher-htmlelement
branch
from
December 8, 2020 22:21
50901dc to
ab546a5
Compare
crisbeto
added
action: merge
Contributor
Author
|
@andrewseguin are you able to review this? Is there anything else I'd need to do? |
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…ameters (angular#21201) Update ScrollDispatcher API to take elements of either ElementRef or HTMLElement. This is to maintain consistency with newer APIs. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ameters
Update ScrollDispatcher API to take elements of either ElementRef or HTMLElement. This is
to maintain consistency with newer APIs.