fix(material-experimental/mdc-select): fix long labels being incorrectly cut off - #21184
Merged
Conversation
google-cla
Bot
added
the
cla: yes
annieyw
added
target: patch
crisbeto
approved these changes
Dec 2, 2020
mmalerba
reviewed
Dec 2, 2020
annieyw
added
action: merge
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MDC based form field is based on the MDC text field which doesn't actually have styles to handle select as the outline/text field is styled individually by each component. There are plans for MDC to consolidate text field/select styles but for now styles have to be added manually.
Before:
After:
Note that floating label for the outline appearance currently has
text-overflow: clipinstead oftext-overflow: ellipsis. https://github.com/material-components/material-components-web/blob/99cfb6bd53f72240fe76852d0fdaa0b82e7dca39/packages/mdc-notched-outline/_mixins.scss#L96