fix(material/slider): unable to assign min/max values if they are more precise than then step - #21155
Merged
Conversation
crisbeto
added
P2
google-cla
Bot
added
the
cla: yes
mmalerba
approved these changes
Dec 1, 2020
…e precise than then step We have some logic that trims the value to the same number of decimals as the `step`, in order to avoid assigning long decimal values. The problem is that if the `min` or `max` are more precise than the `step`, we round up just above the `min` or below the `max`, preventing the user from reaching the end values. These changes add an exception to the rounding for the `min` and `max` values. Fixes angular#21147.
crisbeto
force-pushed
the
21147/slider-min-max-rounding
branch
from
December 1, 2020 19:59
1df263f to
360c429
Compare
mmalerba
pushed a commit
that referenced
this pull request
Dec 4, 2020
…e precise than then step (#21155) We have some logic that trims the value to the same number of decimals as the `step`, in order to avoid assigning long decimal values. The problem is that if the `min` or `max` are more precise than the `step`, we round up just above the `min` or below the `max`, preventing the user from reaching the end values. These changes add an exception to the rounding for the `min` and `max` values. Fixes #21147. (cherry picked from commit e95edad)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some logic that trims the value to the same number of decimals as the
step, in order to avoid assigning long decimal values. The problem is that if theminormaxare more precise than thestep, we round up just above theminor below themax, preventing the user from reaching the end values.These changes add an exception to the rounding for the
minandmaxvalues.Fixes #21147.