Skip to content

fix(material/datepicker): screen reader close button style specificity too low - #21058

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:21043/datepicker-hidden-button
Nov 19, 2020
Merged

fix(material/datepicker): screen reader close button style specificity too low#21058
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:21043/datepicker-hidden-button

Conversation

@crisbeto

Copy link
Copy Markdown
Member

The specificity of the screen reader close button was the same as .mat-raised-button which means that if the button styles are loaded after the datepicker styles, they'll be overridden and will make the button look weird. These changes bump up the specificity a bit to work around the issue.

Fixes #21043.

…y too low

The specificity of the screen reader close button was the same as `.mat-raised-button`
which means that if the button styles are loaded after the datepicker styles, they'll
be overridden and will make the button look weird. These changes bump up the
specificity a bit to work around the issue.

Fixes angular#21043.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 16, 2020
@crisbeto
crisbeto requested a review from mmalerba as a code owner November 16, 2020 15:51
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 16, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2020
@wagnermaciel
wagnermaciel merged commit d9cc055 into angular:master Nov 19, 2020
wagnermaciel pushed a commit that referenced this pull request Nov 19, 2020
…y too low (#21058)

The specificity of the screen reader close button was the same as `.mat-raised-button`
which means that if the button styles are loaded after the datepicker styles, they'll
be overridden and will make the button look weird. These changes bump up the
specificity a bit to work around the issue.

Fixes #21043.

(cherry picked from commit d9cc055)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(DATEPICKER): Close calendar button not placed correctly when opened using button click event

3 participants