Skip to content

fix(material/select): remove focus outline on panel - #21005

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:select-panel-outline
Nov 17, 2020
Merged

fix(material/select): remove focus outline on panel#21005
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:select-panel-outline

Conversation

@crisbeto

Copy link
Copy Markdown
Member

The panel has a focus outline since it has tabindex="-1". We generally don't keep focus on it so the outline isn't shown, but it can happen if the user clicks on the scroll bar. These changes remove the outline.

The panel has a focus outline since it has `tabindex="-1"`. We generally don't keep
focus on it so the outline isn't shown, but it can happen if the user clicks on the
scroll bar. These changes remove the outline.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Nov 10, 2020
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 10, 2020

@wagnermaciel wagnermaciel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2020
@wagnermaciel
wagnermaciel merged commit 44b7e1a into angular:master Nov 17, 2020
wagnermaciel pushed a commit that referenced this pull request Nov 17, 2020
The panel has a focus outline since it has `tabindex="-1"`. We generally don't keep
focus on it so the outline isn't shown, but it can happen if the user clicks on the
scroll bar. These changes remove the outline.

(cherry picked from commit 44b7e1a)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants