Skip to content

fix(material-experimental/mdc-button): narrow down overly-broad selector - #20969

Merged
annieyw merged 1 commit into
angular:masterfrom
crisbeto:mdc-button-broad-selector
Nov 7, 2020
Merged

fix(material-experimental/mdc-button): narrow down overly-broad selector#20969
annieyw merged 1 commit into
angular:masterfrom
crisbeto:mdc-button-broad-selector

Conversation

@crisbeto

@crisbeto crisbeto commented Nov 4, 2020

Copy link
Copy Markdown
Member

Fixes a selector that was targeting all icons on the page, rather than ones inside a button.

@crisbeto
fix(material-experimental/mdc-button): narrow down overly-broad selector
a2bdf03 
Fixes a selector that was targeting all icons on the page, rather than ones inside a button.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Nov 4, 2020
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 4, 2020
@crisbeto crisbeto mentioned this pull request Nov 4, 2020
Merged
mmalerba
mmalerba approved these changes Nov 5, 2020
View reviewed changes

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 5, 2020
@annieyw
annieyw merged commit 92bb1c8 into angular:master Nov 7, 2020
annieyw pushed a commit that referenced this pull request Nov 7, 2020
@crisbeto @annieyw
fix(material-experimental/mdc-button): narrow down overly-broad selec…
4d98bd1 
…tor (#20969)

Fixes a selector that was targeting all icons on the page, rather than ones inside a button.

(cherry picked from commit 92bb1c8)
annieyw pushed a commit that referenced this pull request Nov 7, 2020
@crisbeto @annieyw
fix(material-experimental/mdc-button): narrow down overly-broad selec…
17ef700 
…tor (#20969)

Fixes a selector that was targeting all icons on the page, rather than ones inside a button.

(cherry picked from commit 92bb1c8)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Dec 8, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin
1 more reviewer
@mmalerba mmalerba mmalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @mmalerba @annieyw