feat(material/expansion): allow focus origin to be optional input in focus method - #20912
Conversation
google-cla
Bot
added
the
cla: yes
| const header = fixture.debugElement.query(By.css('mat-expansion-panel-header'))!; | ||
| const headerInstance = header.componentInstance; | ||
|
|
||
| headerInstance.focus('mouse'); |
There was a problem hiding this comment.
This isn't the best test in my opinion. I attempted to focus the button with origin mouse but this requires making this button a mat-button in the component template below.
const button = fixture.debugElement.query(By.css('button'))!;
const buttonInstance = button.componentInstance as MatButton;
buttonInstance.focus('mouse');
This requires importing MatButton as well, which I was having trouble doing and was not sure if we should avoid importing other modules. If this is a better, however, can change it to this approach (assuming it works).
There was a problem hiding this comment.
I think the way you have it here is fine
| const header = fixture.debugElement.query(By.css('mat-expansion-panel-header'))!; | ||
| const headerInstance = header.componentInstance; | ||
|
|
||
| headerInstance.focus('mouse'); |
There was a problem hiding this comment.
I think the way you have it here is fine
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
WHAT: For Angular Material components that have a focus() method, allow for the origin param to be optional and remove the default origin value.
WHY: For cases where the focus() method is called and the origin is already defined, we don’t want to override the origin using focusVia to always be some default value. In many cases, we want to leave the origin unchanged, but if there are cases that need the origin to be updated, allow for this with an optional origin param.