Revert "fix(material/slider): some screen readers announcing long dec… - #20849
Merged
Conversation
…imal values (angular#20760)" This reverts commit 19f5f5c. Reverting this for two reasons: * the truthiness check is a bit too broad, preventing someone from setting the empty string or zero * I'd prefer to have the input named `valuetext` rather than `aria-valuetext` since it's potentially confusing without supporting the `attr.` (I know we do this elsewhere, but I'd like to avoid more use of this pattern)
google-cla
Bot
added
the
cla: yes
wagnermaciel
approved these changes
Oct 22, 2020
crisbeto
approved these changes
Oct 22, 2020
crisbeto
left a comment
crisbeto
left a comment
Member
There was a problem hiding this comment.
LGTM, but wouldn't the new input have to be called valueText rather than valuetext?
Contributor
Author
|
@crisbeto yeah, that also works |
jelbourn
added a commit
that referenced
this pull request
Oct 22, 2020
…imal values (#20760)" (#20849) This reverts commit 19f5f5c. Reverting this for two reasons: * the truthiness check is a bit too broad, preventing someone from setting the empty string or zero * I'd prefer to have the input named `valuetext` rather than `aria-valuetext` since it's potentially confusing without supporting the `attr.` (I know we do this elsewhere, but I'd like to avoid more use of this pattern) (cherry picked from commit cc9758d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…imal values (#20760)"
This reverts commit 19f5f5c.
Reverting this for two reasons:
from setting the empty string or zero
valuetextrather thanaria-valuetextsince it's potentially confusing without supporting the
attr.(I know we do this elsewhere, but I'd like to avoid more use of
this pattern)
cc @crisbeto