fix(cdk/stepper): error if out-of-bounds index is assigned before initialization - #20766
Merged
Merged
Conversation
…tialization Fixes an error if an out-of-bounds index is assigned before the steps are available and the user tries to navigate. Usually we have an assertion that prevents invalid indexes from being assigned, but it doesn't run before initialization, because we don't know how many steps there will be yet. These changes add a check that will revert the index back to 0 if the index is invalid on initialization. Fixes angular#20735.
crisbeto
added
P4
google-cla
Bot
added
the
cla: yes
Member
Author
|
Raising the priority since we got another report about the same issue. |
crisbeto
added
P3
annieyw
pushed a commit
that referenced
this pull request
Nov 3, 2020
…tialization (#20766) Fixes an error if an out-of-bounds index is assigned before the steps are available and the user tries to navigate. Usually we have an assertion that prevents invalid indexes from being assigned, but it doesn't run before initialization, because we don't know how many steps there will be yet. These changes add a check that will revert the index back to 0 if the index is invalid on initialization. Fixes #20735. (cherry picked from commit d3a2718)
annieyw
pushed a commit
that referenced
this pull request
Nov 3, 2020
…tialization (#20766) Fixes an error if an out-of-bounds index is assigned before the steps are available and the user tries to navigate. Usually we have an assertion that prevents invalid indexes from being assigned, but it doesn't run before initialization, because we don't know how many steps there will be yet. These changes add a check that will revert the index back to 0 if the index is invalid on initialization. Fixes #20735. (cherry picked from commit d3a2718)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an error if an out-of-bounds index is assigned before the steps are available and the user tries to navigate. Usually we have an assertion that prevents invalid indexes from being assigned, but it doesn't run before initialization, because we don't know how many steps there will be yet.
These changes add a check that will revert the index back to 0 if the index is invalid on initialization.
Fixes #20735.