Skip to content

feat(cdk/testing): allow for data to be attached to custom event - #20764

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:custom-event-data
Oct 28, 2020
Merged

feat(cdk/testing): allow for data to be attached to custom event#20764
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:custom-event-data

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Allows for data to be attached to an event that is triggered through TestElement.dispatchEvent. This is required in order to simulate some events like animationend. It is limited to primitive data types, because the data has to be JSON-serializeable for Protractor.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: minor This PR is targeted for the next minor release labels Oct 11, 2020
@crisbeto
crisbeto requested a review from a team October 11, 2020 08:00
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2020
Allows for data to be attached to an event that is triggered through `TestElement.dispatchEvent`.
This is required in order to simulate some events like `animationend`.
It is limited to primitive data types, because the data has to be JSON-serializeable for Protractor.
@crisbeto crisbeto changed the title feat(cdk/testing): allow for data to be attached to custm event feat(cdk/testing): allow for data to be attached to custom event Oct 11, 2020

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed merge safe labels Oct 19, 2020
@wagnermaciel
wagnermaciel merged commit f99d0dd into angular:master Oct 28, 2020
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants