Skip to content

Revert "fix(material/slider): some screen readers announcing long dec… - #20753

Merged
wagnermaciel merged 1 commit into
masterfrom
revert-20721
Oct 8, 2020
Merged

Revert "fix(material/slider): some screen readers announcing long dec…#20753
wagnermaciel merged 1 commit into
masterfrom
revert-20721

Conversation

@wagnermaciel

Copy link
Copy Markdown
Contributor

…imal values (#20721)"

This reverts commit d93e16f.

Had to revert this change because a custom aria-valuetext on the component should override what the component sets

@wagnermaciel
wagnermaciel requested a review from mmalerba as a code owner October 8, 2020 19:10
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 8, 2020

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Oct 8, 2020
@wagnermaciel
wagnermaciel merged commit a217509 into master Oct 8, 2020
wagnermaciel added a commit that referenced this pull request Oct 8, 2020
…imal values (#20721)" (#20753)

This reverts commit d93e16f.

(cherry picked from commit a217509)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 8, 2020
@mmalerba
mmalerba deleted the revert-20721 branch November 13, 2020 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants