Skip to content

fix(progress-bar): buffer not rendering correctly on ios - #19346

Merged
annieyw merged 1 commit into
angular:masterfrom
crisbeto:19328/progress-bar-ios-rendering
Nov 4, 2020
Merged

fix(progress-bar): buffer not rendering correctly on ios#19346
annieyw merged 1 commit into
angular:masterfrom
crisbeto:19328/progress-bar-ios-rendering

Conversation

@crisbeto

@crisbeto crisbeto commented May 13, 2020

Copy link
Copy Markdown
Member

Switches to using a 3d transform for the progress bar in order to avoid a rendering issue in buffer mode on iOS Safari.

Fixes #19328.

@crisbeto
fix(progress-bar): buffer not rendering correctly on ios
71327db 
Switches to using a 3d transform for the progress bar in order to avoid a rendering issue in `buffer` mode on iOS Safari.

Fixes angular#19328.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 13, 2020
@crisbeto
crisbeto requested a review from jelbourn as a code owner May 13, 2020 14:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 13, 2020
jelbourn
jelbourn approved these changes May 13, 2020
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 13, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@annieyw
annieyw merged commit 4699f30 into angular:master Nov 4, 2020
annieyw pushed a commit that referenced this pull request Nov 4, 2020
@crisbeto @annieyw
fix(progress-bar): buffer not rendering correctly on ios (#19346)
dae5e32 
Switches to using a 3d transform for the progress bar in order to avoid a rendering issue in `buffer` mode on iOS Safari.

Fixes #19328.

(cherry picked from commit 4699f30)
annieyw pushed a commit that referenced this pull request Nov 4, 2020
@crisbeto @annieyw
fix(progress-bar): buffer not rendering correctly on ios (#19346)
4eb5504 
Switches to using a 3d transform for the progress bar in order to avoid a rendering issue in `buffer` mode on iOS Safari.

Fixes #19328.

(cherry picked from commit 4699f30)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Dec 5, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Progress bar (buffer mode): rendering problem

5 participants

@crisbeto @jelbourn @googlebot @mmalerba @annieyw