Skip to content

Various improvements #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 6 commits into from
Sep 16, 2021
Merged

Various improvements #2961

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
388c078
Add support for other package managers to ng deploy
jamesdaniels Sep 16, 2021
f7f09bb
Add support for other package managers to ng deploy
jamesdaniels Sep 16, 2021
2841cc0
Better AppCheck story for Node.js
jamesdaniels Sep 16, 2021
bdf3178
Better pattern around emulators
jamesdaniels Sep 16, 2021
98febce
Fix spec
jamesdaniels Sep 16, 2021
37db583
Better regex
jamesdaniels Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add support for other package managers to ng deploy
  • Loading branch information
@jamesdaniels
jamesdaniels committed Sep 16, 2021
commit f7f09bb10e81819156130225886d576bb6d1ada5
2 changes: 1 addition & 1 deletion src/schematics/deploy/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ export const deployToCloudRun = async (

// tslint:disable-next-line:no-non-null-assertion
const siteTarget = options.target ?? context.target!.project;

// TODO deploy cloud run
return await firebaseTools.deploy({
only: `hosting:${siteTarget}`,
Expand Down