Revert "feat(core): add support for nested animations"#67632
Open
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Open
Revert "feat(core): add support for nested animations"#67632thePunderWoman wants to merge 1 commit intoangular:mainfrom
thePunderWoman wants to merge 1 commit intoangular:mainfrom
Conversation
thePunderWoman
added
action: review
This reverts commit ea2016a. This reverts the support for nested animations due to the global scope of how nested animations were gathered. This caused issues where on route navigations, all child nodes with animations would be queued and run before the navigation would occur. We'll be revisiting the nested animations with a more tightened scope of when those leave animations will occur. fixes: angular#67552
thePunderWoman
force-pushed
the
revert_66848
branch
from
056ab2f to
f03c6b1
Compare
atscott
approved these changes
Mar 11, 2026
atscott
added
action: merge
thePunderWoman
added
the
merge: caretaker note
Contributor
Author
|
Caretaker note: the failing tests are previously failing and unrelated. This is safe to merge. |
Contributor
|
@thePunderWoman any chance that b4ec3cc could be reverted as well? (as it seems it was only added for this feature) One of my coworkers noticed that fix breaks leave animations when artificially slowing them down for testing with chrome devtools (presumably as the animation duration is now much longer than is calculated with |
Contributor
Author
|
@mattlewis92 We can consider that. We are planning on re-landing nested animations with a more strict scope fairly quickly. So we'll have to see if this fix still applies (it might). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ea2016a.