Skip to content

refactor(core): remove checkNoChanges from the public API.#67474

Open
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:checkNoChanges-remove
Open

refactor(core): remove checkNoChanges from the public API.#67474
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:checkNoChanges-remove

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Mar 5, 2026

It's an internal API.

BREAKING CHANGE: ChangeDetectorRef.checkNoChanges was removed. In tests use fixture.detectChanges() instead.

@JeanMeche JeanMeche added target: major This PR is targeted for the next major release state: blocked on G3 cleanup This change requires a G3 cleanup labels Mar 5, 2026
@pullapprove pullapprove bot requested review from AndrewKushnir and kirjs March 5, 2026 17:23
@JeanMeche
Copy link
Member Author

There are less than a handful of changes to land in G3. It's in progress

@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: core Issues related to the framework runtime labels Mar 5, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 5, 2026
@JeanMeche JeanMeche requested review from atscott and removed request for AndrewKushnir and kirjs March 6, 2026 17:53
@JeanMeche JeanMeche removed the state: blocked on G3 cleanup This change requires a G3 cleanup label Mar 6, 2026
@pullapprove pullapprove bot requested a review from thePunderWoman March 6, 2026 17:53
@JeanMeche JeanMeche added the state: blocked on G3 cleanup This change requires a G3 cleanup label Mar 6, 2026
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and there are no changes in this PR.

reviewed-for: fw-general, public-api

@pullapprove pullapprove bot requested a review from thePunderWoman March 6, 2026 18:07
@thePunderWoman thePunderWoman removed their request for review March 6, 2026 18:27
@JeanMeche JeanMeche force-pushed the checkNoChanges-remove branch from c0422a7 to 19f955d Compare March 11, 2026 14:05
@JeanMeche JeanMeche removed the state: blocked on G3 cleanup This change requires a G3 cleanup label Mar 11, 2026
It's an internal API.

BREAKING CHANGE: `ChangeDetectorRef.checkNoChanges` was removed. In tests use `fixture.detectChanges()` instead.
@JeanMeche JeanMeche force-pushed the checkNoChanges-remove branch from 19f955d to 78590d6 Compare March 11, 2026 14:09
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2026
@JeanMeche JeanMeche removed the request for review from atscott March 11, 2026 16:51
@atscott
Copy link
Contributor

atscott commented Mar 11, 2026

@JeanMeche Can we get a fresh TGP result showing this is good to go?

@JeanMeche
Copy link
Member Author

Will provide one tomorrow.

@atscott atscott added requires: TGP This PR requires a passing TGP before merging is allowed and removed action: merge The PR is ready for merge by the caretaker labels Mar 11, 2026
@JeanMeche
Copy link
Member Author

Passing TGP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change requires: TGP This PR requires a passing TGP before merging is allowed target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants