Skip to content

fix(migrations): Prevent a component from importing itself. #50554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JeanMeche wants to merge 2 commits into from
Closed

fix(migrations): Prevent a component from importing itself. #50554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b095258
fix(migrations): Prevent a component from importing itself.
JeanMeche Jun 2, 2023
5a19bb1
fixup! fix(migrations): Prevent a component from importing itself.
JeanMeche Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,11 @@ export class TemplateTypeCheckerImpl implements TemplateTypeChecker {
}
const emitted = emittedRef.expression;
if (emitted instanceof WrappedNodeExpr) {
if (refTo.node === inContext) {
// Suppress self-imports since components do not have to import themselves.
return null;
}

let isForwardReference = false;
if (emitted.node.getStart() > inContext.getStart()) {
const declaration = this.programDriver.getProgram()
Expand Down
33 changes: 33 additions & 0 deletions packages/core/schematics/test/standalone_migration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,6 +1550,39 @@ describe('standalone migration', () => {
`));
});

it('should not generate a forwardRef for a self import', async () => {
writeFile('decls.ts', `
import {Component} from '@angular/core';

@Component({
selector: 'comp',
template: '<comp/>'
})
export class MyComp {}
`);

writeFile('module.ts', `
import {NgModule} from '@angular/core';
import {MyComp} from './decls';

@NgModule({declarations: [MyComp]})
export class Mod {}
`);

await runMigration('convert-to-standalone');

expect(stripWhitespace(tree.readContent('decls.ts'))).toEqual(stripWhitespace(`
import {Component} from '@angular/core';

@Component({
selector: 'comp',
template: '<comp/>',
standalone: true
})
export class MyComp {}
`));
});

it('should not generate a forwardRef when adding an imported module dependency', async () => {
writeFile('./comp.ts', `
import {Component, NgModule} from '@angular/core';
Expand Down