fix(zone.js): only call jasmine test done function once - #44923

@crisbeto , the changes LGTM, I just wonder is there a reproduce scenario or repo to describe the error case?

I noticed it both in the tests of this repo and the ones in angular/components. Usually you won't see it, because Bazel doesn't log anything if the test run passes. You can get it to show up by adding a test that always fails. I was testing like this:

1. Add a failing test to packages/core/test/util_spec.ts. Something like it('should fail', () => expect(1).toBe(2));. The file doesn't really matter, as long as it's in the test target mentioned below.
2. Run yarn bazel test packages/core/test:test.

@crisbeto , thank you for the reproduce, I did some debug and find out this maybe a bug of asyncTest in zone.js, I will try to fix it in another PR, I will let you know when it is ready for review.

So I had this fixed in aysnc-test.ts as well by only calling the finishCallback once here https://github.com/angular/angular/blob/master/packages/zone.js/lib/zone-spec/async-test.ts#L226. I ended up doing it in jasmine.ts instead, because it seemed like a more appropriate place for a fix that is specific to a warning generated by Jasmine.

@crisbeto , I just figured it out that the issue is a bug of AsyncTestZone, and I created a PR to fix it, #45025, I believe this fix will resolve the jasmine warning about the multiple done issue, and also resolve a lot of other flaky test issues . Please review. Thank you

Closing in favor of #45025.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}