Specialized error when depending on an Ivy-compiled NgModule, 10.2.x edition#41598
Closed
alxhub wants to merge 1 commit into
Closed
Specialized error when depending on an Ivy-compiled NgModule, 10.2.x edition#41598alxhub wants to merge 1 commit into
alxhub wants to merge 1 commit into
Conversation
…lar#41534) When an Ivy NgModule is imported into a View Engine build, it doesn't have metadata.json files that describe it as an NgModule, so it appears to VE builds as a plain, undecorated class. The error message shown in this situation generic and confusing, since it recommends adding an @NgModule annotation to a class from a library. This commit adds special detection into the View Engine compiler to give a more specific error message when an Ivy NgModule is imported. PR Close angular#41534
AndrewKushnir
approved these changes
Apr 13, 2021
AndrewKushnir
approved these changes
Apr 13, 2021
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
(though I think that may not be needed, since it's a backport)
zarend
added
the
area: compiler
alxhub
added
target: patch
Member
Author
|
Caretaker: this is a backport of #41534 to the |
zarend
approved these changes
Apr 13, 2021
zarend
added
target: lts
Contributor
|
@josephperrott what's the processes for merging into the previous major version? Would I merge this like normal using |
Member
|
@zarend The merge tooling supports merging as normal into active LTS branches with the |
jelbourn
approved these changes
Apr 13, 2021
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
petebacondarwin
approved these changes
Apr 14, 2021
petebacondarwin
left a comment
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
|
Closed by commit f630f33 |
zarend
pushed a commit
that referenced
this pull request
Apr 14, 2021
…) (#41598) When an Ivy NgModule is imported into a View Engine build, it doesn't have metadata.json files that describe it as an NgModule, so it appears to VE builds as a plain, undecorated class. The error message shown in this situation generic and confusing, since it recommends adding an @NgModule annotation to a class from a library. This commit adds special detection into the View Engine compiler to give a more specific error message when an Ivy NgModule is imported. PR Close #41534 PR Close #41598
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.