1. Added to_s to adcloudapi exception so that we can just output ex and ...#7
Merged
Conversation
Contributor
rosscdh
commented
Jun 7, 2013
rosscdh
commented
- Added to_s to adcloudapi exception so that we can just output ex and not ex.message (seems to be what everyone is doing and will help with debugging)
- Added better exception handling.. in the else case the api was simply returning a standard error with the response.status.. which is pretty useless in some cases (ssl,timeouts,etc) so now it throws ab UnknownError that acts in the standard adcloud manner
…nd not ex.message (seems to be what everyone is doing and will help with debugging) 2. Added better exception handling.. in the else case the api was simply returning a standard error with the response.status.. which is pretty useless in some cases (ssl,timeouts,etc) so now it throws ab UnknownError that acts in the standard adcloud manner
ghost
assigned
Contributor
|
LGTM |
rosscdh
added a commit
that referenced
this pull request
Jun 10, 2013
1. Added to_s to adcloudapi exception so that we can just output ex and ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.