Isolate CLI test report output in temporary directories - #503

🏁 Script executed:

#!/bin/bash
set -eu
printf '%s\n' '--- repository conventions ---'
find /tmp/coderabbit-repo-knowledge/xctesthtmlreport-xctesthtmlreport-d7dca354 -maxdepth 2 -type f -name '*.md' -print
printf '%s\n' '--- changed file diff ---'
git diff -- Tests/XCTestHTMLReportTests/CliTests.swift
printf '%s\n' '--- relevant source ---'
cat -n Tests/XCTestHTMLReportTests/CliTests.swift | sed -n '1,135p'

Repository: XCTestHTMLReport/XCTestHTMLReport

Length of output: 6866

🏁 Script executed:

#!/bin/bash
set -eu
printf '%s\n' '--- repository convention ---'
cat /tmp/coderabbit-repo-knowledge/xctesthtmlreport-xctesthtmlreport-d7dca354/learnings/repo-wide.md
printf '%s\n' '--- bound helper definitions and callers ---'
rg -n -C 8 'makeScratchDirectory|parseReportDocument|xchtmlreportCmd|assertAttachmentsExist' Tests XCTestHTMLReport
printf '%s\n' '--- URL construction and attachment path generation ---'
rg -n -C 6 'URL\(fileURLWithPath|isDirectory|TestResults\.xcresult|screenshot-flow|showText' . -g '*.swift' -g '*.m' -g '*.h'

Repository: XCTestHTMLReport/XCTestHTMLReport

Length of output: 36558

🏁 Script executed:

#!/bin/bash
set -eu
printf '%s\n' '--- makeScratchDirectory implementation ---'
cat -n Tests/XCTestHTMLReportTests/CliTests.swift | sed -n '154,178p'
printf '%s\n' '--- package deployment settings ---'
rg -n -C 3 'platforms|macOS|swift-tools-version' Package.swift Package.resolved *.swift 2>/dev/null || true
printf '%s\n' '--- standalone Foundation probe availability ---'
if command -v swift >/dev/null 2>&1; then
  swift - <<'SWIFT'
import Foundation
let base = URL(fileURLWithPath: "/tmp/xchr-example")
let directoryBase = URL(fileURLWithPath: "/tmp/xchr-example", isDirectory: true)
for url in [base, directoryBase] {
    let resolved = URL(string: "TestResults.xcresult/attachment.png", relativeTo: url)!
    print("base=\(url.absoluteString) hasDirectoryPath=\(url.hasDirectoryPath) resolved=\(resolved.absoluteURL.path)")
}
SWIFT
else
  echo "swift unavailable"
fi

Repository: XCTestHTMLReport/XCTestHTMLReport

Length of output: 2504

🌐 Web query:

Apple Foundation URL(string:relativeTo:) base URL directory semantics trailing slash file URL

💡 Result:

In Apple's Foundation framework, the URL(string:relativeTo:) initializer (and its NSURL equivalent) follows standard URL resolution rules, where the presence or absence of a trailing slash in the baseURL significantly impacts how relative strings are resolved [1][2][3]. For apps linked on or after iOS 17 (and aligned versions), URL parsing is governed by RFC 3986 [1][2]. Under these semantics: Directory Semantics and Trailing Slashes To treat a base URL as a directory (ensuring relative paths are appended correctly), the base URL must end with a trailing slash [1][3]. If the baseURL does not include a trailing slash, the final path component of that base URL is treated as a file rather than a directory, and is discarded when the relative string is resolved [3]. Example of expected behavior: If you have a base URL https://example.com/folder (no trailing slash): Resolving file.html against it results in https://example.com/file.html (the folder component is replaced). If you have a base URL https://example.com/folder/ (with a trailing slash): Resolving file.html against it results in https://example.com/folder/file.html (the relative string is appended to the directory) [1][4][3]. File URL Considerations When working with file URLs specifically, the same logic applies [4]. Methods such as init(fileURLWithPath:isDirectory:relativeTo:) allow you to explicitly define whether the path represents a directory [4][5]. Using these explicit initializers or ensuring your base file URL has a trailing slash is necessary to maintain directory semantics [1][4]. Recent Changes and Appending Behavior Note that modern Swift Foundation APIs, such as appending(component:directoryHint:), have specific behaviors regarding trailing slashes. While older behaviors sometimes struggled with double-encoding or redundant slashes, current implementations are designed to be more predictable: - Appending a component while specifying isDirectory: true will ensure a trailing slash is present [6]. - Recent internal updates have worked to prevent redundant slash encoding (e.g., folder%2F/) while maintaining the distinction between directory and file components [7][6]. For robust construction, it is generally recommended to use URLComponents for complex URL manipulation or the explicit appending methods with appropriate directoryHint parameters, rather than relying solely on string-based relative resolution [8].

Citations:

• 1: https://developer.apple.com/documentation/foundation/nsurl/init(string:relativeto:)
• 2: https://developer.apple.com/documentation/foundation/url/init(string:relativeto:)
• 3: https://stackoverflow.com/questions/16582350/nsurl-urlwithstringrelativetourl-is-clipping-relative-url
• 4: https://developer.apple.com/documentation/foundation/nsurl
• 5: https://github.com/apple/swift-corelibs-foundation/blob/730ccd46d6b4dcb7a2f09927645aa291a55528bb/Foundation/URL.swift
• 6: GitHub pull request 2051 in swiftlang/swift-foundation (link omitted to avoid creating a cross-reference)
• 7: GitHub issue 1931 in swiftlang/swift-foundation (link omitted to avoid creating a cross-reference)
• 8: https://stackoverflow.com/questions/76860343/why-does-swift-urls-initstring-string-relativeto-url-add-only-the-protoc