Skip to content

2.5.2-pre.53adfaf Version Bump - #395

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
version-bump/2.5.2-pre.53adfaf
Closed

github-actions[bot] wants to merge 1 commit into
mainfrom
version-bump/2.5.2-pre.53adfaf

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Bumping version from 2.5.1 to 2.5.2-pre.53adfaf

@github-actions
github-actions Bot requested a review from tylervick August 7, 2026 20:12
@tylervick

Copy link
Copy Markdown
Member

Closing — this bump is wrong and would regress the version on main.

Version.swift is currently 3.0.0-pre; this PR would set it back to 2.5.2-pre.53adfaf.

Cause: the tag 3.0.0rc1 is not valid semver (semver requires 3.0.0-rc1, with a hyphen), so reecetech/version-increment could not parse it, fell back to the last parseable tag 2.5.1, and incremented that.

The bump_version job should not run for prereleases at all — bumping the version after a release candidate makes no sense regardless of parsing. Fixing that now.

@tylervick tylervick closed this Aug 7, 2026
@tylervick
tylervick deleted the version-bump/2.5.2-pre.53adfaf branch August 7, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant