Skip to content

445 arbitrary ROI#965

Merged
AdvancedImagingUTSW merged 5 commits into
TheDeanLab:developfrom
annie-xd-wang:445-arbitrary-roi
Aug 15, 2024
Merged

445 arbitrary ROI#965
AdvancedImagingUTSW merged 5 commits into
TheDeanLab:developfrom
annie-xd-wang:445-arbitrary-roi

Conversation

@annie-xd-wang
Copy link
Copy Markdown
Collaborator

@annie-xd-wang annie-xd-wang commented Aug 14, 2024

No description provided.

@AdvancedImagingUTSW
Copy link
Copy Markdown
Collaborator

AdvancedImagingUTSW commented Aug 14, 2024

Small bug found when manually adjusting ROI Boundary widgets...

  File "C:\Users\Dean-Lab\Desktop\navigate\src\navigate\controller\sub_controllers\camera_settings.py", line 481, in update_fov
    if value < 0 or value > max_value or value % step_value:
TypeError: '<' not supported between instances of 'str' and 'int'

@AdvancedImagingUTSW AdvancedImagingUTSW self-requested a review August 15, 2024 00:12
AdvancedImagingUTSW
AdvancedImagingUTSW approved these changes Aug 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AdvancedImagingUTSW AdvancedImagingUTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I have confirmed that it works on one microscope.

@AdvancedImagingUTSW AdvancedImagingUTSW linked an issue Aug 15, 2024 that may be closed by this pull request
Add ability to set arbitrary ROI #445
Closed
@AdvancedImagingUTSW AdvancedImagingUTSW merged commit 5802d8c into TheDeanLab:develop Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdvancedImagingUTSW AdvancedImagingUTSW AdvancedImagingUTSW approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to set arbitrary ROI

2 participants

@annie-xd-wang @AdvancedImagingUTSW