Skip to content

948 mip display#964

Merged
AdvancedImagingUTSW merged 33 commits into
developfrom
948-mip-display
Aug 17, 2024
Merged

948 mip display#964
AdvancedImagingUTSW merged 33 commits into
developfrom
948-mip-display

Conversation

@AdvancedImagingUTSW
Copy link
Copy Markdown
Collaborator

No description provided.

Adds a new tab to the camera view notebook.
I want to creat ea BaseViewController with the basic functionality for the viewer. This will be inherited by the CameraViewController and the MIPViewController. Hopefully this avoids code duplication.
Still a bit chaotic. Lots of features that are only partially implemented in the original camera view. Trying to use inheritance to simply matters.
Also consolidate crosshair logic.
Set the channel appropriately.

```        channel_idx, _ = self.identify_channel_index_and_slice()
        self.image_metrics["Channel"].set(channel_idx + 1)```
cleanup the attributes. Proper initialization of attributes...
Clean up camera view controller attributes.
Removed some liabilities with the slider.

Currently, some of the logic in the __init__ is duplicated from the initialize method.
Time to test this on a real system. If it works, then I will add the lazy loader next...
Very close. Need to remove some duplicated code and clean out the last few bugs.
I think I am running into threading problems now...
Trying to make sure that all of the autoscaling, transpose, min/max widgets update accordingly in the slider view.

When I tried to do this, the update_min_max_counts function should call process_image, but that then calls update_min_max_counts again, causing a recursive error.
Tests are a mess.
@AdvancedImagingUTSW AdvancedImagingUTSW linked an issue Aug 14, 2024 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 79.85401% with 138 lines in your changes missing coverage. Please review.

Project coverage is 54.01%. Comparing base (efe8e98) to head (aaf70d9).
Report is 61 commits behind head on develop.

Files Patch % Lines
...navigate/controller/sub_controllers/camera_view.py 79.22% 123 Missing ⚠️
.../navigate/controller/sub_controllers/keystrokes.py 41.17% 10 Missing ⚠️
...igate/view/main_window_content/display_notebook.py 91.37% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #964      +/-   ##
===========================================
+ Coverage    53.51%   54.01%   +0.50%     
===========================================
  Files          176      177       +1     
  Lines        18975    19428     +453     
===========================================
+ Hits         10154    10494     +340     
- Misses        8821     8934     +113     
Flag Coverage Δ
unittests 54.01% <79.85%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdvancedImagingUTSW AdvancedImagingUTSW merged commit e346b95 into develop Aug 17, 2024
@AdvancedImagingUTSW AdvancedImagingUTSW deleted the 948-mip-display branch March 6, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MIP Display

2 participants