948 mip display#964
Merged
Merged
Conversation
Adds a new tab to the camera view notebook.
I want to creat ea BaseViewController with the basic functionality for the viewer. This will be inherited by the CameraViewController and the MIPViewController. Hopefully this avoids code duplication.
Still a bit chaotic. Lots of features that are only partially implemented in the original camera view. Trying to use inheritance to simply matters.
Also consolidate crosshair logic.
Set the channel appropriately.
``` channel_idx, _ = self.identify_channel_index_and_slice()
self.image_metrics["Channel"].set(channel_idx + 1)```
cleanup the attributes. Proper initialization of attributes...
Clean up camera view controller attributes.
Removed some liabilities with the slider. Currently, some of the logic in the __init__ is duplicated from the initialize method.
Time to test this on a real system. If it works, then I will add the lazy loader next...
Very close. Need to remove some duplicated code and clean out the last few bugs.
I think I am running into threading problems now...
Trying to make sure that all of the autoscaling, transpose, min/max widgets update accordingly in the slider view. When I tried to do this, the update_min_max_counts function should call process_image, but that then calls update_min_max_counts again, causing a recursive error.
Tests are a mess.
Closed
@abc.abstractmethod forces child classes to have methods...
annie-xd-wang
approved these changes
Aug 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #964 +/- ##
===========================================
+ Coverage 53.51% 54.01% +0.50%
===========================================
Files 176 177 +1
Lines 18975 19428 +453
===========================================
+ Hits 10154 10494 +340
- Misses 8821 8934 +113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.