637 dichroic control 1#950
Merged
Merged
Conversation
Removed context manager __enter__ and __exit__, since we never use these... Should be able to load a dichroic turret now by calling type ASICubeSlider
Add function to pull filter wheel names, if provided. Automatically populates the View with the filter wheel names...
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #950 +/- ##
===========================================
- Coverage 52.98% 52.97% -0.02%
===========================================
Files 177 177
Lines 19110 19143 +33
===========================================
+ Hits 10126 10141 +15
- Misses 8984 9002 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
And some comments too.
Collaborator
Author
|
Going to merge. Works as anticipated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.