926#930
Merged
Merged
Conversation
I'm thinking we should move our gui parameters out of the configuration.yaml file. Currently, in the channels_tab_controller, the initialize method does not call self.set_spinbox_range_limits. This is where the gui parameters are called from the configuration file. However, if the configuration file is not set up properly, then no error handling is in place and this will throw a terminal error.
So that we can have a more centrally organized location for the GUI parameters (step size, etc), we now can load a GUI file into the Manager dictionary.
When evaluating the tests on my personal machine, I noticed that the test_main_application_window hung, so now I force it to exit. Also realized that I messed up the variable input arguments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #930 +/- ##
===========================================
+ Coverage 51.79% 51.84% +0.04%
===========================================
Files 179 179
Lines 19110 19091 -19
===========================================
- Hits 9898 9897 -1
+ Misses 9212 9194 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Johnhaug223
approved these changes
Jul 2, 2024
Collaborator
Johnhaug223
left a comment
Johnhaug223
left a comment
There was a problem hiding this comment.
Testing out actively changing the focus increment was successful, tried with changing the increment to different values (from 0.1 to 10), and it seemed to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a bit of a mess and I am simply trying to get PR #926 ready for merging...